Call view.dispatch within setDiagnostics?

v6
1

I wonder if the setDiagnostics interface might be improved by taking view as a parameter rather than state, in which case it would call view.dispatch automatically to dispatch the effects?

Before:

view.dispatch(setDiagnostics(state, diagnostics))
(easy to forget the view.dispatch wrapper and wonder why nothing’s happening)

After:

setDiagnostics(view, diagnostics)

2

No, this design is intentional, in that it allows you to combine the return value of setDiagnostics with other transaction specs to build up a bigger transaction.

1 Like