Feature request: `domAtPos` side parameter

lishid · December 8, 2021, 9:51pm

I’m working with the experimental vim mode port from cm5 by nightwing and I’m trying to find a way to get the DOM element on the right side of a position.

Given there isn’t a side parameter, it makes it hard to predictably get the correct DOM element to measure for styling.

github.com

lishid/cm6-vim-mode-experiment/blob/cabcfb68c0b71af7a3cd05a419d045c368b1ac46/src/block-cursor.ts#L152

    
      
              return null;
            if (cursor.anchor < cursor.head) head--;
            if (cm.state.overwrite) hCoeff = 0.2;
            else if (vim.status) hCoeff = 0.5;
          }
          
          
if (fatCursor) {
            let pos = view.coordsAtPos(head, cursor.assoc || 1);
            if (!pos) return null;
            let base = getBase(view);
            let domAtPos = view.domAtPos(head);
            let node = domAtPos ? domAtPos.node : view.contentDOM;
            if (!(node instanceof HTMLElement)) {
              node = node.parentNode;
            }
            let style = getComputedStyle(node as HTMLElement);
            let fontFamily = style.fontFamily;
            let fontSize = style.fontSize;
          
          
  let letter = head < view.state.doc.length && view.state.sliceDoc(head, head + 1);
            if (!letter || letter == "\n" || letter == "\r") letter = "\xa0";

lishid · December 8, 2021, 10:22pm

Actually, this is still achievable without a side property, by manually looking around the DOM position resulting from the return value.

marijn · December 9, 2021, 7:05am

Since none of the core functionality needs this, and I can’t even think of a robust way to define it when there are zero-length widgets at the position, I prefer to not add this for the time being.

lishid · December 9, 2021, 7:31am

Yeah agreed, it’s kind of difficult to frame this and I’ve ran into multiple edge cases with widgets and replacements already. Thanks for your time.