MapMode.simple for Block Widget Decorations?

v6
1

Hi team,

Thank you so much for all the hard work on the project! I have been really enjoying working on it, and exploring the codebase.

I am creating a block widget decoration:

const widgetLine = editorState.doc.lineAt(state.range.from);

return RangeSet.of([
  Decoration.widget({
    widget: new MyWidget(state),
    block: true,
  }).range(widgetLine.from),
]);

and was wondering if there is anyway to keep the widget visible through deletion?

I know currently, that block widgets have a default MapMode of MapMode.TrackBefore but because of this when I delete through the line the widget is placed it is removed from the DOM.

I would love if it was possible to map the widget to the next valid position after deleting through the line. Which I believe is the behavior of MapMode.Simple. But I can’t find a way to configure the Widget to propagate this setting to the Decoration, and I don’t believe it’s possible since PointDecoration determines it’s mapMode like so:

this.mapMode = !block ? MapMode.TrackDel : startSide <= 0 ? MapMode.TrackBefore : MapMode.TrackAfter

I was wondering if there was another way to emulate this. In an ideal world I would love to avoid having to create a new Decoration.widget().

Thank you again for all your support and this great project!

-Chris

2

Does this patch look like it would help you do this?

1 Like
3

Hi Marijn, thank you so much for the response and the quick patch. This definitely fixes the update() call and results in the correct RangeSet being returned . But I am still seeing the widget removed from the editor.

I will do some additional work tonight to trace through the code and understand better the logic, and report back.

Thank you again!

4

On closer look, I didn’t really think this patch through. RangeSet has an optimization that allows it to drop chunks of ranges that are entirely deleted, in which case it won’t even look at the map mode for those ranges. Thus, the approach in my patch just won’t work. I’ve revered my patch. You’ll have to take care of re-adding these in your own code after all.

5

Makes sense. Also thinking it through a bit more, for block width widget which are expected to span the entire line we need to perform more calculations to position them to the beginning of the line upon which they are moving onto, we can’t just take the cursor position.

Will look into this on my side.

Thank you again!