Extra line being inserted

[lvrpl]

Sorry, I got another for you. I think its related to this one I submitted a few months ago:

Unexpected behaviour in MergeView

I’m seeing newlines being inserted when I don’t expect them in the MergeView. This happens in Chrome/Edge, but not Firefox. You should be able to reproduce the problem with the demo here: To reproduce: Method 1 - On the left side of the MergeView delete all the text and then hit the delete key (delete, not backspace) and it’ll insert newlines. Method 2 - On the left side of the MergeView do select all and then hit any character. It’ll insert the character, but also a newline afterwards. W…

You can reproduce the problem by going to your demo here on Chrome: Try CodeMirror

Then on the either side select all and enter any character. It’ll delete the selected text and enter the character on the first line. But it will also add an empty line too.

The extra line behaviour is what the older issue did and they both only happen on Chrome.

Thank you

[marijn]

@lvrpl

You can reproduce the problem by going to your demo here on Chrome: Try CodeMirror

Did you maybe forget to create a specific link (with ‘share’ button)? If I use the built-in merge view example, I don’t see the problem you describe happening.

[lvrpl]

You should be able to reproduce it with the built in merge view (though it happens in non-merge view). But it only has the problem in Edge/Chrome, not Firefox.

Short clip: https://drive.google.com/file/d/1Mkuw43aS2DFNyc_HxA-mNi9fAUvOSRBK/view?usp=drive_link

[marijn]

Oh, your link to the MergeView thread threw me off. Somehow this issue does not happen in a merge view, but I can reproduce it in a regular editor. This patch should help.

Fix bogus newline insertion on typing over multiple lines at end of document

[lvrpl]

Thank you! You’re awesome!