Unexpected behaviour in MergeView

v6
1

I’m seeing newlines being inserted when I don’t expect them in the MergeView. This happens in Chrome/Edge, but not Firefox.

You should be able to reproduce the problem with the demo here:

To reproduce:

Method 1 - On the left side of the MergeView delete all the text and then hit the delete key (delete, not backspace) and it’ll insert newlines.

Method 2 - On the left side of the MergeView do select all and then hit any character. It’ll insert the character, but also a newline afterwards.

When I look at the transaction, it has changes with a TextLeaf of text [‘‘, ‘‘] in the first method and [‘(char)’, ‘‘] in the second method. So it’s adding a new line for that.

I did some debugging with the source code and it looks like the problem originates from the DOMChange. The domChange.text will have some weird unprintable character tagged on the end. The charCodeAt for that character is 65535.

The deleteCharFowards command itself behaves correctly and returns false. It’s the DOMChange that adds that the mysterious input.

That’s what I’ve figured out, but I’m not sure what the right fix would be.

2

Thanks for the reports. The first issue was caused, as you diagnosed, by the browser going off and making a weird DOM change after the command for delete returned false. The first patch below should prevent that. The second was an issue in the DOM text reader, triggered by the presence of a spacer widget after the content. That should be handled by the second patch.

1 Like
3

That’s great, thank you so much!